gh-143164: Fix incorrect error message for ctypes bitfield overflow #143165
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous message did not match the actual overflow check and omitted the bitfield size, making it misleading. Update the message to reflect the correct condition and report all relevant values. Signed-off-by: Yongtao Huang <[email protected]>
Contributor
|
Maybe we can add a test to check the message to ensure that we don't break it up in the future? |
Contributor
Author
Thanks for the review! The test case has now been added. |
aisk
reviewed
Dec 25, 2025
Co-authored-by: AN Long <[email protected]>
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
I have a suggestion for test example.
serhiy-storchaka
approved these changes
Dec 25, 2025
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I think the message should be updated too.
serhiy-storchaka
added
needs backport to 3.13
Contributor
Author
Updated, thanks for the feedback. |
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Sorry for misleading. I meant the error message tested in the test should be updated. Otherwise the test will fail.
Contributor
Author
|
Oh, sorry for my mistake. Updated it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous message did not match the actual overflow check and omitted the bitfield size, making it misleading. Update the message to reflect the correct condition and report all relevant values.