Skip to content

Assert that testcases are not empty #20453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A5rocks wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −0
Open

Assert that testcases are not empty #20453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee9ad1c
Assert that testcases are not empty
A5rocks Dec 21, 2025
9dbcbcd
Apply suggestion from @A5rocks
A5rocks Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions mypy/test/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,19 @@ def runtest(self) -> None:
# TODO: add a better error message for when someone uses skip and xfail at the same time
elif self.xfail:
self.add_marker(pytest.mark.xfail)

if (
not [line for line in self.input if line.strip()]
and "Empty" not in self.name
and not [
file
for file in self.files
# these files are added based on other things
if os.path.basename(file[0]) not in ("typing.pyi", "_typeshed.pyi", "builtins.pyi")
]
):
raise AssertionError(f"{self.name} is empty.")

parent = self.getparent(DataSuiteCollector)
assert parent is not None, "Should not happen"
suite = parent.obj()
Expand Down