Skip to content

Adding test for CadenceWakeWordQuantizer #16356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RahulC7 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding test for CadenceWakeWordQuantizer #16356

RahulC7 wants to merge 4 commits into from
+162 −4

Conversation

@RahulC7
Copy link
Contributor

@RahulC7 RahulC7 commented Dec 21, 2025

Summary: As title.

Differential Revision: D88898933

Copilot AI review requested due to automatic review settings December 21, 2025 22:16
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16356

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 257c67e with merge base 6785e1f (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 21, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 21, 2025

@RahulC7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88898933.

@github-actions
Copy link

github-actions bot commented Dec 21, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 21, 2025
@RahulC7 @facebook-github-bot
Adding test for CadenceWakeWordQuantizer (pytorch#16356)
86e6811 
Summary:

As title.

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 21, 2025
@RahulC7 @facebook-github-bot
Adding test for CadenceWakeWordQuantizer (pytorch#16356)
7eaa78a 
Summary:

As title.

Differential Revision: D88898933
Copilot AI reviewed Dec 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds test coverage for four Cadence quantizers that were previously missing tests: CadenceWakeWordQuantizer, CadenceWith16BitConvActivationsQuantizer, CadenceWithLayerNormQuantizer, and CadenceWithSoftmaxQuantizer. The TODO comments for these quantizers are removed from the exclusion list.

Key changes:

  • Adds five new test cases to QUANTIZER_ANNOTATION_TEST_CASES covering conv1d, conv2d, softmax, layer_norm, and add operations
  • Implements five new graph builder helper methods for constructing test graphs for each operation type
  • Removes four quantizers from EXCLUDED_FROM_ANNOTATION_TESTING set

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

backends/cadence/aot/tests/test_quantizer_ops.py
Comment on lines +128 to +136
(
"add_A8W8",
lambda self: self._build_add_graph(),
CadenceWakeWordQuantizer(),
torch.ops.aten.add.Tensor,
qconfig_A8W8.output_activation,
# For add: both inputs are activations
[qconfig_A8W8.input_activation, qconfig_A8W8.input_activation],
),
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CadenceWakeWordQuantizer includes both AddPattern and CatPattern (for add and cat operations), but this test only covers the add operation. Consider adding a test case for the cat operation to ensure complete coverage of CadenceWakeWordQuantizer's functionality.

Copilot uses AI. Check for mistakes.
@RahulC7 @meta-codesync
Adding test for CadenceWith16BitConvActivationsQuantizer
e3c5217 
Summary: Add annotation tests for CadenceWith16BitConvActivationsQuantizer covering both conv1d and conv2d operations.

Differential Revision: D88895865
@RahulC7 @meta-codesync
Adding test for CadenceWithLayerNormQuantizer
6ce0bec 
Differential Revision: D88896712
@RahulC7 @meta-codesync
Adding Test for CadenceWithLayerNormQuantizer
399f502 
Differential Revision: D88898823
@RahulC7 @meta-codesync
Adding test for CadenceWakeWordQuantizer (pytorch#16356)
257c67e 
Summary:
Pull Request resolved: pytorch#16356

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@hsharma35 hsharma35 hsharma35 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RahulC7 @hsharma35