fix: make description consistent with link-external-filter example code#10806
Closed
mcanouil wants to merge 6 commits intoquarto-dev:mainfrom
Closed
fix: make description consistent with link-external-filter example code#10806mcanouil wants to merge 6 commits intoquarto-dev:mainfrom
link-external-filter example code#10806mcanouil wants to merge 6 commits intoquarto-dev:mainfrom
Conversation
mcanouil
changed the title
link-external-filter examplelink-external-filter example code
Collaborator
|
I don't know what's going on with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example for the
link-external-filterconfig is confusing because it includes the word "custom" in the regex, which is not explained. This pull request updates the example to clarify thathttp://www.quarto.org/customandhttps://www.quarto.org/customare treated as internal links, while others are considered external. This resolves #10780.Companion PR:
link-external-filterexample code quarto-web#1332