Conversation
Member
|
Thank you for the PR. |
Contributor
Author
|
There's actually not much overlap - this PR mostly modifies the decoder, and the other PR only the encoder. The encoder changes here are just in defining the constant type set (no conflict there) and extracting a toBytes() utility method which can be reverted or ignored since it is not of much consequence. |
Contributor
Author
|
I split the last commit further, so now the encoder changes are on a separate commit, in case that helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split into 3 commits to make it a bit easier to follow. Highlights include getting rid of the BufPos class (lots of unnecessary object allocations), extracting the pattern matching code into a separate class, replacing Character calls with literals (since it deals with bytes, not chars, so there's no need for the overhead) a bit of renaming and little refactoring for clarity.