-
Notifications
You must be signed in to change notification settings - Fork 194
feat: add util function for common keyboard event handling #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zombieJ
merged 6 commits into
react-component:master
from
aojunhao123:feat/keycode-util
Dec 30, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
91c7769
feat: add util function for better keyboard event handling
aojunhao123 db5b908
chore: adjust
aojunhao123 12a1346
chore: adjust
aojunhao123 d07a208
add test case
aojunhao123 88d5bbb
test case
aojunhao123 2bda4bc
chore: adjust
aojunhao123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import KeyCode from '../src/KeyCode'; | ||
| import { createEvent } from '@testing-library/react'; | ||
|
|
||
| describe('KeyCode.isEditableTarget', () => { | ||
| it('check editable target', () => { | ||
| const eleList = [ | ||
| { | ||
| element: 'window', | ||
| expected: false, | ||
| }, | ||
| { | ||
| element: 'div', | ||
| expected: false, | ||
| }, | ||
| { | ||
| element: 'input', | ||
| expected: true, | ||
| }, | ||
| { | ||
| element: 'textarea', | ||
| expected: true, | ||
| }, | ||
| { | ||
| element: 'select', | ||
| expected: true, | ||
| }, | ||
| { | ||
| element: 'div', | ||
| isContentEditable: true, | ||
| expected: true, | ||
| }, | ||
| ]; | ||
|
|
||
| eleList.forEach(({ element, isContentEditable, expected }) => { | ||
| const target = | ||
| element === 'window' ? window : document.createElement(element); | ||
| if (isContentEditable) { | ||
| // mock isContentEditable cause JSDOM don't support it | ||
| Object.defineProperty(target, 'isContentEditable', { value: true }); | ||
| } | ||
| const event = createEvent.keyDown(target) as KeyboardEvent; | ||
| target.dispatchEvent(event); | ||
| const result = KeyCode.isEditableTarget(event); | ||
|
|
||
| expect(result).toBe(expected); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.