feat(x2a): show branch with icon and highlight #2314
+34
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Contributor
|
I'll let @mareklibra merge if there is any UI edge case I'm not aware of |
mareklibra
reviewed
Feb 12, 2026
| <br /> | ||
| {url} | ||
| <div className={classes.root}> | ||
| <span className={classes.chip}> |
Member
There was a problem hiding this comment.
It would be better to use https://v4.mui.com/components/chips/ to stay aligned with the rest of the Backstage.
| })); | ||
|
|
||
| const GitBranchIcon = () => ( | ||
| <SvgIcon fontSize="small" viewBox="0 0 24 24"> |
Member
There was a problem hiding this comment.
I can not find the icon in MUI, so this is good to use.
mareklibra
requested changes
Feb 12, 2026
Member
mareklibra
left a comment
mareklibra
left a comment
There was a problem hiding this comment.
Better to use existing components if possible
Signed-off-by: Eloy Coto <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change on how to see the branch, is a bit cleaner for the end user: