Add support for UTF-8 encoded passwords#430
Merged
HarlemSquirrel merged 3 commits intoruby-ldap:masterfrom Aug 22, 2025
Merged
Conversation
Member
HarlemSquirrel
left a comment
HarlemSquirrel
left a comment
There was a problem hiding this comment.
Thanks for this!
The branch now needs to be updated for tests to run but it looks like you don't have your account set so I can update that branch for you for this PR. Please update this branch from the latest master here so the tests can run.
Member
|
@frankwalentowski thanks for working on this! Do you have a moment to update this branch from the latest master? |
Contributor
Author
|
Sorry, I've been distracted with other things for the last few months. |
Member
|
@frankwalentowski looks like just one Rubocop offense and this should be good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing creation of SHA1/SHA256 digest in Net::LDAP::Password when given password string has an UTF8 encoding.