Consolidate tag filtering to _all suffix for AND logic - scopes and parameters

[Copilot]

What is the goal of this PR and why is this important?

Consolidate duplicate tag filtering scope implementations and unify parameter naming. The codebase had both sector_names/category_names and sector_names_all/category_names_all doing identical AND logic with different implementations. The _all suffix now explicitly and consistently indicates AND semantics (items must have ALL specified tags) throughout both scopes and HTTP parameters, distinguishing from typical OR-based scopes.

How did you approach the change?

Phase 1: TagFilterable concern consolidation

• Removed tag_names method (GROUP BY/HAVING approach)
• Kept only tag_names_all method (subquery approach, avoids ONLY_FULL_GROUP_BY errors with eager loading)
• Removed category_names and sector_names scopes, kept only _all versions

Phase 2: Complete parameter renaming
Renamed ALL HTTP parameter references throughout the application:

# Before
params[:sector_names]
params[:category_names]

# After  
params[:sector_names_all]
params[:category_names_all]

Updated files (29 total):

• Models (8): Story, Event, Organization, Facilitator, Quote, CommunityNews, Resource, Tutorial - updated search_by_params methods
• Services (2): TaggingSearchService (method signature), WorkshopSearchService
• Controllers (2): TaggingsController, AhoyTracking concern
• Helpers (2): TaggingsHelper (method signature), TagMatrixHelper
• JavaScript (1): tags_sync_list_heights_controller.js
• Views (14): taggings index/partials, facilitators, categories, sectors, admin activity views - fixed missed variable references in taggings/index.html.erb
• Tests (4): taggings_spec.rb, tagging_search_service_spec.rb, taggings_multiselect_filter_spec.rb, sectors/_tagging_label.html.erb_spec.rb

Phase 3: System test coverage

• Added comprehensive system test (spec/system/taggings_multiselect_filter_spec.rb) to validate multiselect filter functionality on both tags and taggings index pages
• Test coverage includes: single/multiple selection, AND logic validation, checkbox state preservation, empty state handling, and filter clearing

Phase 4: Test fixes

• Fixed all 6 failing tests related to parameter renaming:
  • Updated view spec to use sector_names_all= parameter
  • Used regex /explore by combination/i for case-insensitive text matching (handles "EXPLORE BY COMBINATION" uppercase rendering)
  • Added URL pattern validation to verify proper delimiter format while accepting either parameter order (e.g., sector_names_all=(Adult--Youth|Youth--Adult))

Anything else to add?

Net reduction of ~40 lines. Complete consistency achieved - both scope names AND parameter names now use _all suffix to clearly indicate AND logic semantics throughout the entire application. Fixed bug where taggings index view was still using old @sector_names and @category_names variables. Added comprehensive test coverage to ensure the multiselect functionality works correctly with the new parameter naming convention. All tests now pass with proper assertions that validate both functionality and URL formatting while being resilient to implementation details like parameter ordering.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[maebeale]

@copilot i want the param name to have all in it too

[maebeale]

@copilot add a system test to validate this multiselect on the bottom of tags and taggings indexes works correctly

[maebeale]

@copilot do what's needed to get the failing tests to pass