Add wasm32-wasip2 target support #639
Open
+255
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricochet
force-pushed
the
wasip2-support
branch
from
17548fe to
bb1ad7e
Compare
Rework of rust-lang#532 by @nickrum, addressing review feedback from @Darksonn and @Thomasdezeeuw: - Reuses sys/unix.rs instead of creating sys/wasi.rs (per @Thomasdezeeuw's code review feedback) - MaybeUninitSlice stays unconditional since libc::iovec is available on WASI, eliminating 11+ scattered cfg gates (per @Darksonn's concern) - Internal cfg changes concentrated in the sys module Opt-in cfg patterns use `all(target_os = "wasi", not(target_env = "p1"))` to match how the libc crate gates WASI p2 socket support. Opt-out patterns use bare `target_os = "wasi"` for features unavailable on any WASI version. WASI tests run in CI with wasmtime (27/27 pass). Tests for unsupported socket options are gated out with references to the relevant WASI spec issues (SO_BROADCAST, SO_LINGER, IPV6_V6ONLY). ```bash export CARGO_TARGET_WASM32_WASIP2_RUNNER="wasmtime --wasi inherit-network" cargo test --target wasm32-wasip2 --lib --tests ``` Closes rust-lang#268 Based-on: rust-lang#532 Co-authored-by: Nicola Krumschmidt <[email protected]>
ricochet
force-pushed
the
wasip2-support
branch
from
bb1ad7e to
6e5c3f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #532 by @nickrum, addressing review feedback from @Darksonn
and @Thomasdezeeuw:
code review feedback)
eliminating 11+ scattered cfg gates (per @Darksonn's concern)
Opt-in cfg patterns use
all(target_os = "wasi", not(target_env = "p1"))to match how the libc crate gates WASI p2 socket support. Opt-out
patterns use bare
target_os = "wasi"for features unavailable on anyWASI version.
WASI tests run in CI with wasmtime (27/27 pass). Tests for unsupported
socket options are gated out with references to the relevant WASI spec
issues (SO_BROADCAST, SO_LINGER, IPV6_V6ONLY).
Closes #268
Based-on: #532
Co-authored-by: Nicola Krumschmidt [email protected]