-
Notifications
You must be signed in to change notification settings - Fork 679
feat(web-api): Add support for admin.users.getExpiration #2451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2451 +/- ##
=======================================
Coverage 93.09% 93.10%
=======================================
Files 40 40
Lines 11240 11250 +10
Branches 713 713
=======================================
+ Hits 10464 10474 +10
Misses 764 764
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@misscoded LGTM and thanks so much for including the generated responses with this change 🙏 ✨
I left a comment about one of those changes, but no blockers for this method 🤖
| ok?: boolean; | ||
| provided?: string; | ||
| ts?: string; | ||
| message?: ChatStopStreamResponseMessage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪓 issue(non-blocking): This should be included in the Java generated logs but I'm finding tests aren't covering this for me. Let's keep note to follow up on this - I think using generated types is correct while "message" is optional.
👁️🗨️ ramble: But I wouldn't be opposed to reverting changes of this file if that seems uncertain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zimeg Why would this suddenly go missing?
Summary
Adds support for
admin.users.getExpiration(and updates generated responses). See documentation.Resolves #2420.
Requirements (place an
xin each[ ])