Skip to content

Conversation

@misscoded
Copy link
Contributor

@misscoded misscoded commented Dec 10, 2025

Summary

Adds support for admin.users.getExpiration (and updates generated responses). See documentation.

Resolves #2420.

Requirements (place an x in each [ ])

@misscoded misscoded added this to the [email protected] milestone Dec 10, 2025
@misscoded misscoded requested review from vegeris and zimeg December 10, 2025 22:26
@misscoded misscoded self-assigned this Dec 10, 2025
@misscoded misscoded added semver:minor enhancement M-T: A feature request for new functionality area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` labels Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.10%. Comparing base (bb284c6) to head (294512b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2451   +/-   ##
=======================================
  Coverage   93.09%   93.10%           
=======================================
  Files          40       40           
  Lines       11240    11250   +10     
  Branches      713      713           
=======================================
+ Hits        10464    10474   +10     
  Misses        764      764           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.79% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.87% <ø> (ø)
web-api 98.11% <100.00%> (+<0.01%) ⬆️
webhook 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@misscoded misscoded marked this pull request as ready for review December 18, 2025 21:50
@misscoded misscoded requested a review from a team as a code owner December 18, 2025 21:50
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misscoded LGTM and thanks so much for including the generated responses with this change 🙏 ✨

I left a comment about one of those changes, but no blockers for this method 🤖

ok?: boolean;
provided?: string;
ts?: string;
message?: ChatStopStreamResponseMessage;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 issue(non-blocking): This should be included in the Java generated logs but I'm finding tests aren't covering this for me. Let's keep note to follow up on this - I think using generated types is correct while "message" is optional.

👁️‍🗨️ ramble: But I wouldn't be opposed to reverting changes of this file if that seems uncertain?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zimeg Why would this suddenly go missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for the admin.users.getExpiration API

3 participants