Implement SearchKeys on tpmkms #927
Open
+207
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the experimental SearchKeys method on the tpmkms. With this method.
This commit fixes empty results on unsigned binaries when we search for keys in the secure enclave.
1 task
hslatman
reviewed
Jan 15, 2026
| } | ||
|
|
||
| // SearchKeys searches for keys according to the query URI in the request. By | ||
| // default, with the query "tpmkms:", it will return all keys and attestation |
Member
There was a problem hiding this comment.
Minor, but this makes the distinction a little bit clearer:
Suggested change
| // default, with the query "tpmkms:", it will return all keys and attestation | |
| // default, with the query "tpmkms:", it will return all application and attestation |
| // - "tpmkms:" will return all keys and AKs managed by the KMS | ||
| // - "tpmkms:ak=true" will return all AKs managed by the KMS | ||
| // - "tpmkms:ak=false" will return all the keys managed by the KMS | ||
| // - "tpmkms:name=my-name" will only return the key with the selected name |
Member
There was a problem hiding this comment.
This means it defaults to the behavior of ak=false? If so, that sounds OK.
Comment on lines
+1287
to
+1288
| // - "tpmkms:name=my-name;ak=false" will only return the key with the selected name | ||
| // |
Member
There was a problem hiding this comment.
It might be an option to include support for searching application keys by the AK they were attested by. Not a blocker, though.
| }}, | ||
| }, | ||
| }, assert.NoError}, | ||
| {"ok enpty", fields{sim, nil, nil}, args{&apiv1.SearchKeysRequest{Query: "tpmkms:name=not-found"}}, &apiv1.SearchKeysResponse{}, assert.NoError}, |
Member
There was a problem hiding this comment.
Suggested change
| {"ok enpty", fields{sim, nil, nil}, args{&apiv1.SearchKeysRequest{Query: "tpmkms:name=not-found"}}, &apiv1.SearchKeysResponse{}, assert.NoError}, | |
| {"ok empty", fields{sim, nil, nil}, args{&apiv1.SearchKeysRequest{Query: "tpmkms:name=not-found"}}, &apiv1.SearchKeysResponse{}, assert.NoError}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the experimental SearchKeys method on the tpmkms. With this method.