Skip to content

Conversation

@patricios-space
Copy link
Collaborator

@patricios-space patricios-space commented Dec 29, 2025

@patricios-space patricios-space marked this pull request as ready for review December 29, 2025 14:57
@patricios-space patricios-space requested a review from a team as a code owner December 29, 2025 14:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses missing OnRamp disabling logic and null handling in the Router contract. The changes ensure that the Router properly handles disabled destination chains by checking both for missing OnRamp entries and zero addresses, rather than throwing exceptions that would fail transactions.

Key Changes:

  • Modified Router to handle disabled chains gracefully by returning error messages instead of failing transactions
  • Added zero address checks alongside missing OnRamp checks
  • Refactored error handling logic into reusable helper functions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
contracts/contracts/ccip/router/contract.tolk Added zero address validation for OnRamps and extracted error handling into reusable helper functions
contracts/tests/ccip/router/Router.getFee.spec.ts Updated tests to expect graceful error handling and added test for zero address scenario
contracts/tests/ccip/router/Router.ccipSend.spec.ts Updated tests to expect graceful error handling and added test for zero address scenario

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@patricios-space patricios-space force-pushed the fix/router/disabled-onramps branch from 3f04c6d to dec966f Compare January 6, 2026 17:47
@patricios-space patricios-space force-pushed the fix/router/disabled-onramps branch from dec966f to 988aa9f Compare January 6, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants