Skip to content

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Dec 31, 2025

These log as raw bytes otherwise, which is spammy and unreadable.

@jmank88 jmank88 requested a review from a team as a code owner December 31, 2025 15:43
@github-actions
Copy link
Contributor

👋 jmank88, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88 jmank88 requested a review from bolekk December 31, 2025 15:44
@jmank88 jmank88 enabled auto-merge December 31, 2025 15:51
@cl-sonarqube-production
Copy link

@jmank88 jmank88 added this pull request to the merge queue Dec 31, 2025
Copy link

@trunk-io trunk-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Test Results: Unrelated Failure

Affected failures:

  1. Workflow Run: Integration Tests

What Broke

This failure appears to be unrelated to the changes in this PR. The CI failure is not caused by the changes introduced in this PR. The failure is due to an external, unrelated issue within the CI environment or the existing codebase. The PR only adds a String() method to the WorkflowID type, and a code search confirms this new method is not being called anywhere in the codebase. The CI failure logs are generic, indicating 'Process completed with exit code 1.' without any specific error messages or stack traces that could be linked to the PR's changes.

Autofix Options

You can use our MCP server to get AI assistance with debugging and fixing these failures.

  • Use MCP in your IDE to debug the issue. Try Help me fix CI failures from 0gQip4KH to get started.

View all test uploads

Merged via the queue into develop with commit 5c011b2 Dec 31, 2025
206 of 208 checks passed
@jmank88 jmank88 deleted the workflowid-string branch December 31, 2025 16:32
@trunk-io
Copy link

trunk-io bot commented Dec 31, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants