Cherry-pick with test fixes#36
Cherry-pick with test fixes#36nanjekyejoannah wants to merge 1 commit intosoftdevteam:regression_fixfrom
Conversation
|
|
||
| from test import test_support | ||
|
|
||
There was a problem hiding this comment.
A few blank line additions have crept into this commit, which might make merge conflicts a bit more likely later. Probably worth putting things back as they were.
|
Please squash. |
1 similar comment
|
Please squash. |
85cde37 to
2a1224d
Compare
|
Squashed |
|
Ah, this has failed because CI is set on the |
|
The PR targets |
|
Does that mean we don't want the |
I will explain more tommorrow. This is going to be merged to migration eventually, that was we discussed when we created this branch IIRC. |
|
OK. |
|
Is this one OK to merge? |
|
@nanjekyejoannah Shall we merge this? |
|
Hmm, this took over an hour in our CI system. I'll try again in case it was a one-off, but I'm wondering if something's making things take unduly long. |
|
@nanjekyejoannah In CI a Python process is currently taking 37GiB of RAM, so I think something's gone wrong with this PR. I wonder if it's because of this: |
Cherry-pick with fixes, to make string warning ready.