gh-36043 - configureMessageConvertersList #36049
Closed
+77
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
haydenrear
force-pushed
the
feature/add-message-converter-list-configurer
branch
3 times, most recently
from
c67f3aa to
aeae7b9
Compare
Member
|
@haydenrear thanks for this PR, but we cannot process it at the moment.
Thanks |
bclozel
added
the
status: waiting-for-feedback
Adds ability to add message converter at specific index to builders, and propagates through to java.util.List.add(idx, ...) Signed-off-by: Hayden Rear [email protected]
haydenrear
force-pushed
the
feature/add-message-converter-list-configurer
branch
from
aeae7b9 to
c9eafda
Compare
Author
Hi @bclozel I have squashed and ran the build locally and pushed. Thanks! |
spring-projects-issues
added
status: feedback-provided
Member
|
Thanks @haydenrear but it seems that your commits aren't signed with the DCO (even though it looks like they are in the commit message). At this stage, I'm not sure how we will resolve #36043 so I'll close this PR to avoid spending time processing a PR that we cannot merge. |
bclozel
added
status: declined
haydenrear
restored the
feature/add-message-converter-list-configurer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-36043
Adds ability to change message converters list before it's returned by registering consumer using configureMessageConvertersList
Signed-off-by: Hayden Rear [email protected]