Add tests for global DOM engine behavior#145
Merged
thibaudcolas merged 2 commits intomainfrom Jan 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DOM.domandHTML.__init__callsDOM.use, causing the engine to be global across allHTMLinstances and leading to surprising last-wins and thread-safety issues.Description
tests/test_html.py:test_engine_is_global_for_existing_instancesandtest_engine_switching_affects_previous_instancethat exercise engine selection across multipleHTMLinstances.DOM.STRINGandDOM.STRING_COMPATto demonstrate that switching engines affects previously createdHTMLinstances.Testing
make testorpytest tests/test_html.py::TestHTML::test_engine_is_global_for_existing_instances tests/test_html.py::TestHTML::test_engine_switching_affects_previous_instance.Codex Task