Flatten OR/AND operators in EXPLAIN AST output #85
+60
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add collectBooleanOperands helper function to flatten chained OR and AND
expressions into a flat list, matching ClickHouse's EXPLAIN AST format.
Previously, "a OR b OR c" would produce nested output like:
Function or
ExpressionList (2)
Function or (2)
a
b
c
Now it produces the expected flat format:
Function or
ExpressionList (3)
a
b
c
This change applies the flattening in three places:
- explainBinaryExpr (main expression handling)
- explainAliasedExpr (aliased expressions)
- explainWithElement (WITH clause elements)
This fixes 419 explain tests.
This reverts commit 5f5d3a9.
1. SampleRatio: Convert decimal values like 0.1 to fractions like 1/10 in EXPLAIN output, matching ClickHouse's format for SAMPLE clauses. Added floatToFraction() helper to find simple fraction representation. 2. Aliased negative integers: Always output aliased negative integer literals as "Literal Int64_-N" instead of "Function negate". The previous code only did this in subquery context, but ClickHouse always uses the literal format for aliased expressions. Fixes 4 explain tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add collectBooleanOperands helper function to flatten chained OR and AND
expressions into a flat list, matching ClickHouse's EXPLAIN AST format.
Previously, "a OR b OR c" would produce nested output like:
Function or
ExpressionList (2)
Function or (2)
a
b
c
Now it produces the expected flat format:
Function or
ExpressionList (3)
a
b
c
This change applies the flattening in three places:
This fixes 419 explain tests.