Updates and Fixes to Make spark-memory work on opensource spark#4
Open
AndrewKL wants to merge 6 commits intosquito:masterfrom
Open
Updates and Fixes to Make spark-memory work on opensource spark#4AndrewKL wants to merge 6 commits intosquito:masterfrom
AndrewKL wants to merge 6 commits intosquito:masterfrom
Conversation
…vented spark from stating the ExecutorPlugin cr https://code.amazon.com/reviews/CR-12240438
…mple error message generated by Yarn
…s were implemented
squito
approved these changes
Aug 23, 2019
Owner
squito
left a comment
There was a problem hiding this comment.
Thanks for doing this -- yes it totally makes sense, this was last updated before the api was finalized.
Other than removing the extra file, this looks good, thanks!
| @@ -0,0 +1,37 @@ | |||
| # -*-perl-*- | |||
Owner
There was a problem hiding this comment.
can you remove this file from the pr please?
Owner
|
Also btw, a lot of the functionality of this plugin was recently merged to master in apache spark (SPARK-26329 / apache/spark#23767). Its not exactly the same -- that makes it easier to capture metrics at a faster rate and still include something reasonable in the event logs. But the major problem with that approach is we don't get any info from right before the executor gets killed suddenly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates and Fixes to Make spark-memory work on opensource spark