fix: unknown word report config change #8261 #8273
Draft
+140
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason3S
changed the title
Collaborator
|
Need any more help? |
Jason3S
reviewed
Jan 4, 2026
Collaborator
Jason3S
left a comment
Jason3S
left a comment
There was a problem hiding this comment.
We just need to add some tests:
We will need a fixture:
issue-8261
It can be added to test/index.test.mts. See issue-4870 as an example.
Jason3S
reviewed
Jan 5, 2026
| * | ||
| * default is 'all' unless overridden by CSpell settings | ||
| */ | ||
| report?: 'all' | 'simple' | 'typos' | 'flagged'; |
Collaborator
There was a problem hiding this comment.
Suggested change
| report?: 'all' | 'simple' | 'typos' | 'flagged'; | |
| report?: 'all' | 'simple' | 'typos' | 'flagged' | undefined; |
This is to support having the default be undefined.
packages/cspell-eslint-plugin/src/plugin/defaultCheckOptions.cts
Outdated
Show resolved
Hide resolved
| import assert from 'node:assert'; | ||
|
|
||
| import { spellCheck, type SpellCheckOptions } from './spellCheck.mjs'; | ||
| import type { UnknownWordsChoices } from 'cspell-lib'; |
Collaborator
There was a problem hiding this comment.
Thank you for adding the unit tests.
Co-authored-by: Jason Dent <[email protected]> Signed-off-by: Bence Márkus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PRcontains the changes required to resolvecspell ESLint plugin: support typos-only reporting (CLI --report typos / unknownWords report-common-typos) #8261