✨(frontend) add onboarding modal with help menu button#1868
✨(frontend) add onboarding modal with help menu button#1868
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
e37119e to
646716a
Compare
|
Size Change: +11 kB (+0.26%) Total Size: 4.21 MB
|
c568bd8 to
8895b75
Compare
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/on-boarding/components/OnBoarding.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/on-boarding/components/OnBoarding.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/on-boarding/hooks/useOnboardingSteps.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
translations.json is automatically edited, what you made in it will be overwritten when the translations are pulled from Crowdin.
src/frontend/apps/impress/src/features/on-boarding/components/OnBoarding.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/left-panel/hooks/useHelpMenuOptions.tsx
Outdated
Show resolved
Hide resolved
e320212 to
5d3a15e
Compare
integrate onboarding feature accessible from left panel help menu ✨(frontend) add docs onboarding and help memu Introduce an onboarding to guide users through core features.
Ensure onboarding entrypoint and modal navigation work end-to-end.
5d3a15e to
fc645eb
Compare
AntoLC
left a comment
There was a problem hiding this comment.
Ah nice job, almost pixel perfect 😉
Some returns about the codes then we are good.
src/frontend/apps/impress/src/features/left-panel/components/LeftPanelHelpMenu.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/LeftPanelHelpMenu.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/LeftPanelHelpMenu.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/on-boarding/hooks/useOnboardingSteps.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/LeftPanelHelpMenu.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/on-boarding/components/OnboardingStepImage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This file should not be edited from dev PR as it will be overwrited.
| const options = useHelpMenuOptions({ onOpenOnboarding: openModal }); | ||
| const footerLink = { | ||
| label: t('Learn more docs features'), | ||
| href: '', |
There was a problem hiding this comment.
You should see either with Robin or Virgile about the link, we should leverage the Next Router as well, to have a shallow redirection. If we don't have a link to propose we should not display this part.
65337c7 to
31b4ef9
Compare
99f234b to
5f29b6e
Compare
| footerLink={{ | ||
| label: t('Learn more docs features'), | ||
| href: '', | ||
| href: 'https://docs.numerique.gouv.fr/docs/335e43b5-9e16-4798-a0b4-912e44c7135e/', |
There was a problem hiding this comment.
We have to add this url as a environment variables, others instances are not using https://docs.numerique.gouv.fr.
To do so, we will give the possibility the override it thanks to the theme configuration file:
You should add:
{
"onboarding: {
"learn_more_url": ""
},
"footer": {
....docs/src/frontend/apps/impress/src/core/config/api/useConfig.tsx
Lines 14 to 27 in 3378544
If the url is empty, do not display the footerLink.
Don't add this url, I will add it on our own instance directly.
There was a problem hiding this comment.
This component seems overkill now, can we directly add Image where it is needed.
5f29b6e to
e042264
Compare

Purpose
Add a Docs onboarding in the help menu and introduce a guided onboarding flow to help users discover editing, formatting, sharing, and template features.
Proposal
features/on-boarding/) with steps, assets, and hooks.