Skip to content

✨(frontend) add onboarding modal with help menu button#1868

Open
Ovgodd wants to merge 16 commits intomainfrom
feat/onboarding-modal
Open

✨(frontend) add onboarding modal with help menu button#1868
Ovgodd wants to merge 16 commits intomainfrom
feat/onboarding-modal

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Feb 6, 2026

Purpose

Add a Docs onboarding in the help menu and introduce a guided onboarding flow to help users discover editing, formatting, sharing, and template features.

Proposal

  • Add the onboarding feature (features/on-boarding/) with steps, assets, and hooks.
  • Put onboarding into the left panel help menu.
  • Accessibility improvements need to be implemented in the UI Kit.
  • Open of first connection i not handle here yet

@Ovgodd Ovgodd requested a review from AntoLC February 6, 2026 14:05
@Ovgodd Ovgodd self-assigned this Feb 6, 2026
@Ovgodd Ovgodd changed the title Feat/onboarding modal ✨(frontend) add onboarding modal with help menu button Feb 6, 2026
@socket-security
Copy link

socket-security bot commented Feb 6, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​gouvfr-lasuite/​ui-kit@​0.18.7 ⏵ 0.19.573 +2100100 +2599 +1100

View full report

@Ovgodd Ovgodd force-pushed the feat/onboarding-modal branch 2 times, most recently from e37119e to 646716a Compare February 6, 2026 14:09
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Size Change: +11 kB (+0.26%)

Total Size: 4.21 MB

Filename Size Change
apps/impress/out/_next/static/39d5a144/_buildManifest.js 830 B +830 B (new file) 🆕
apps/impress/out/_next/static/chunks/8495.js 68.9 kB +3.95 kB (+6.08%) 🔍
apps/impress/out/_next/static/chunks/pages/_app.js 600 kB +5.58 kB (+0.94%)
apps/impress/out/_next/static/css/1b41e63cc2efc1f2.css 47.6 kB +47.6 kB (new file) 🆕
apps/impress/out/_next/static/css/6a59910f4653194c.css 0 B -46.2 kB (removed) 🏆
apps/impress/out/_next/static/d5272f34/_buildManifest.js 0 B -831 B (removed) 🏆

compressed-size-action

@Ovgodd Ovgodd marked this pull request as ready for review February 9, 2026 07:55
@Ovgodd Ovgodd force-pushed the feat/onboarding-modal branch 2 times, most recently from c568bd8 to 8895b75 Compare February 9, 2026 08:50
@socket-security
Copy link

socket-security bot commented Feb 9, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translations.json is automatically edited, what you made in it will be overwritten when the translations are pulled from Crowdin.

@Ovgodd Ovgodd requested a review from AntoLC February 11, 2026 11:26
@Ovgodd Ovgodd force-pushed the feat/onboarding-modal branch from e320212 to 5d3a15e Compare February 11, 2026 11:26
@Ovgodd Ovgodd added the feature add a new feature label Feb 11, 2026
@Ovgodd Ovgodd force-pushed the feat/onboarding-modal branch from 5d3a15e to fc645eb Compare February 11, 2026 15:46
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice job, almost pixel perfect 😉

Some returns about the codes then we are good.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be edited from dev PR as it will be overwrited.

const options = useHelpMenuOptions({ onOpenOnboarding: openModal });
const footerLink = {
label: t('Learn more docs features'),
href: '',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should see either with Robin or Virgile about the link, we should leverage the Next Router as well, to have a shallow redirection. If we don't have a link to propose we should not display this part.

@Ovgodd Ovgodd force-pushed the feat/onboarding-modal branch from 65337c7 to 31b4ef9 Compare February 12, 2026 11:32
@Ovgodd Ovgodd force-pushed the feat/onboarding-modal branch 3 times, most recently from 99f234b to 5f29b6e Compare February 12, 2026 13:19
@AntoLC AntoLC linked an issue Feb 13, 2026 that may be closed by this pull request
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is almost done, so not in this one, but when we will add another part in the help menu I think actually we should create a feature help, and inside this feature help we will have the onboarding codes (so no feature onboarding anymore), and all the others part as well:

Image

footerLink={{
label: t('Learn more docs features'),
href: '',
href: 'https://docs.numerique.gouv.fr/docs/335e43b5-9e16-4798-a0b4-912e44c7135e/',
Copy link
Collaborator

@AntoLC AntoLC Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to add this url as a environment variables, others instances are not using https://docs.numerique.gouv.fr.
To do so, we will give the possibility the override it thanks to the theme configuration file:

You should add:

{
  "onboarding: {
     "learn_more_url": ""
  },
  "footer": {
      ....

interface ThemeCustomization {
favicon?: {
light: LinkHTMLAttributes<HTMLLinkElement>;
dark: LinkHTMLAttributes<HTMLLinkElement>;
};
footer?: FooterType;
home: {
'with-proconnect'?: boolean;
'icon-banner'?: Imagetype;
};
translations?: Resource;
header?: HeaderType;
waffle?: WaffleType;
}

If the url is empty, do not display the footerLink.


Don't add this url, I will add it on our own instance directly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component seems overkill now, can we directly add Image where it is needed.

@Ovgodd Ovgodd force-pushed the feat/onboarding-modal branch from 5f29b6e to e042264 Compare February 13, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature add a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants