Open
Conversation
Owner
|
Your implementation of MyQueue using two stacks is correct and efficient. The code is clean and well-organized. The use of a private rebalance function to transfer elements from st1 to st2 when needed is a good practice. Strengths:
Areas for improvement:
One potential issue: in your rebalance function, you transfer all elements from st1 to st2. This is correct. However, ensure that you only do this when st2 is empty. Your condition in pop and peek checks for st2.empty(), which is correct. Keep up the good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemeted Queue using Stacks.
Designed a HashMap