Should Uninstall remove all test classes?#14
Open
NReilingh wants to merge 5 commits intotSQLt-org:mainfrom
Open
Should Uninstall remove all test classes?#14NReilingh wants to merge 5 commits intotSQLt-org:mainfrom
NReilingh wants to merge 5 commits intotSQLt-org:mainfrom
Conversation
This procedure runs DropClass on all schemas that are marked with a tSQLt.TestClass extended property. This can be used to easily reset your development environment, especially for those of us who make heavy use of query shortcuts (like RunAll) in lieu of GUI tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think, since test classes are created and usually destroyed using tSQLt procedures, that the user expectation for running tSQLt.Uninstall is that all of their test classes will be removed as well, since after that point, the DropClass procedure is no longer available.
So, I propose that Uninstall should remove all test classes automatically.
(I haven't verified the last test here works as expected — if this sounds like a good idea to people, I'll double-check and make sure everything works.