Add default client, accessible through TempoDB module#28
Open
gevans wants to merge 5 commits intotempodb:v1.0from
hashrabbit:feature/default-client
Open
Add default client, accessible through TempoDB module#28gevans wants to merge 5 commits intotempodb:v1.0from hashrabbit:feature/default-client
gevans wants to merge 5 commits intotempodb:v1.0from
hashrabbit:feature/default-client
Conversation
* Configuring the default client is done through `TempoDB.configure`, a pattern found frequently in other Ruby/Rails libraries. * The `TempoDB` module delegates `Client` methods to `TempoDB.client`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the ability to use a default client in applications which have only one database and a single set of keys. In one particular use case, in a Rails initializer, one would be able to use:
Standard
TempoDB::Clientinstance methods can then be called as class methods ofTempoDB:Edit: The test suite appeared to be broken when I initially forked the repo. I took extra care not to make any changes to
TempoDB::Clientuntil I have time to see what's up with that. The changes I've made do have specs however. :)