Use discovery for ML API client instead of static file#381
Open
cymarechal-devoteam wants to merge 3 commits intotensorflow:masterfrom
Open
Use discovery for ML API client instead of static file#381cymarechal-devoteam wants to merge 3 commits intotensorflow:masterfrom
cymarechal-devoteam wants to merge 3 commits intotensorflow:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using CloudTuner previously led to erroneous URLs in API calls, e.g.
This was due to the static discovery file in
src/python/tensorflow_cloud/tuner/api/ml_public_google_rest_v1.jsonwhich statically points tohttps://us-central1-ml.googleapis.com.This modification aims to remove the static dependency to
us-central1and instead use the dynamic version of Discovery.Reference: