pipeline: allocate on specific heap #10539
Open
+65
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
requested review from
abonislawski,
dbaluta,
iuliana-prodan,
lbetlej,
lgirdwood,
lyakh,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull request overview
Adds heap-aware pipeline allocation so pipelines (and related objects) can be placed on specific memory domains, including user-space heaps.
Changes:
- Extends
pipeline_new()to accept a heap parameter and stores it instruct pipeline - Updates IPC and unit tests to use the new
pipeline_new(NULL, ...)default-heap calling pattern - Adds a Zephyr userspace test that allocates a pipeline from the user heap and validates placement
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| zephyr/test/userspace/test_ll_task.c | Adds a userspace test that creates/frees a pipeline on the userspace heap |
| test/cmocka/src/audio/pipeline/pipeline_new.c | Updates cmocka test to the new pipeline_new() signature |
| src/ipc/ipc4/helper.c | Updates IPC4 pipeline creation to pass default heap (NULL) |
| src/ipc/ipc3/helper.c | Updates IPC3 pipeline creation to pass default heap (NULL) |
| src/include/sof/audio/pipeline.h | Adds heap parameter + pipeline->heap field and updates doc comment |
| src/audio/pipeline/pipeline-schedule.c | Allocates pipeline tasks from the pipeline heap |
| src/audio/pipeline/pipeline-graph.c | Allocates/frees pipeline objects from a selectable heap |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| /* allocate new pipeline */ | ||
| p = rzalloc(SOF_MEM_FLAG_USER, sizeof(*p)); | ||
| p = sof_heap_alloc(heap, SOF_MEM_FLAG_USER, sizeof(*p), 0); |
There was a problem hiding this comment.
Using an explicit alignment of 0 relies on sof_heap_alloc() default behavior. Since this allocates a struct, it’s safer/clearer to pass an explicit alignment (e.g., __alignof__(*p) / alignof(struct pipeline) or the project’s default alignment constant) to prevent misalignment if a heap implementation changes.
Suggested change
| p = sof_heap_alloc(heap, SOF_MEM_FLAG_USER, sizeof(*p), 0); | |
| p = sof_heap_alloc(heap, SOF_MEM_FLAG_USER, sizeof(*p), __alignof__(*p)); |
softwarecki
approved these changes
Feb 11, 2026
lyakh
reviewed
Feb 12, 2026
zephyr/test/userspace/test_ll_task.c
Outdated
|
|
||
| /* Free pipeline */ | ||
| ret = pipeline_free(p); | ||
| zassert_equal(ret, 0, "pipeline free failed"); |
Collaborator
Author
There was a problem hiding this comment.
Why not, need to change for V2, so I'll change this as well (although not a fan of the million variants of ztest asserts).
Collaborator
There was a problem hiding this comment.
not a fan
oh, I find them cute
abonislawski
approved these changes
Feb 12, 2026
lgirdwood
approved these changes
Feb 12, 2026
| struct pipeline *pipeline_new(uint32_t pipeline_id, uint32_t priority, uint32_t comp_id, | ||
| struct create_pipeline_params *pparams) | ||
| struct pipeline *pipeline_new(struct k_heap *heap, uint32_t pipeline_id, uint32_t priority, | ||
| uint32_t comp_id, struct create_pipeline_params *pparams) |
Member
There was a problem hiding this comment.
Fwiw, I will be changing this to pass in a vregion soon.
Collaborator
Author
|
Fail in cmocka, debugging ongoing. |
Add a heap parameter to pipeline allocation functions. This makes it possible to control how allocations are done with pipeline granularity and makes it possible to move pipelines to user-space. Signed-off-by: Kai Vehmanen <[email protected]>
Add a simple test to allocate a pipeline using a user-space memory heap and verify creation is successful. Signed-off-by: Kai Vehmanen <[email protected]>
Fix copy and paste error in documentation for pipeline_prepare(). Signed-off-by: Kai Vehmanen <[email protected]>
Fix copy and paste error in documentation for pipeline_schedule_copy(). Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
202602-pipe-allow-custom-heap
branch
from
3e60e0a to
c51bfa6
Compare
Collaborator
Author
|
V2 pushed:
|
lyakh
approved these changes
Feb 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a heap parameter to pipeline allocation functions. This makes it possible to control how allocations are done with pipeline granularity and makes it possible to move pipelines to user-space.
Second patch adds a test case that uses the new interface to create pipelline in user-space memory domain.
Third patch is a trivial documentation fix to pipeline.h.