[pull] master from kevoreilly:master #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace print statements with logging in kvm.py
Updated the KVM machinery module to use the logging module instead of print statements for warnings when interface or VNC port information cannot be retrieved. This improves consistency and allows better control over log output.
1. Adding Standard Logging: Imported logging and replaced print() calls with log.warning(), ensuring consistency with the project's logging practices.
2. Hardening XML Parsing: In store_vnc_port, I added a check if graphics is not None: before trying to access .get("port"). This prevents an AttributeError if the machine configuration lacks a graphics device.
3. Fixing Error Messages: Corrected the error message in store_vnc_port to say "Can't get VNC port" instead of "Can't get iface".
* Update modules/machinery/kvm.py
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )