CI: Node 20 + pnpm test; isolate legacy template from workspace#7
CI: Node 20 + pnpm test; isolate legacy template from workspace#7
Conversation
Exclude legacy template from pnpm workspace to keep CI and installs focused on the spec-aligned toolchain.
|
Verdict: APPROVE WITH MINOR REVISIONS CI is a must-have; this workflow is straightforward and aligned with Node 20 + pnpm. Excluding the legacy template from the workspace is also the right call to keep CI focused on the spec-aligned toolchain. What I verified locally
Good
Minor revisions / follow-ups (non-blocking)
|
…/work-ci-security
- Run pnpm typecheck in CI - Add a non-blocking pnpm audit step for visibility - Add dependabot config focused on the pnpm workspace
|
Follow-up: minor revision items addressed.
|
|
Verdict: APPROVE WITH MINOR REVISIONS Re-reviewing with the latest commits on this branch: CI is now meaningfully stronger and aligns with the spec-aligned workspace. What changed since my last review
What I checked
Minor follow-ups (non-blocking)
|
Implements the final roadmap item (CI + security hardening) by adding GitHub Actions CI and reducing the dependency surface area that CI installs/tests.
What changed
pnpm teston pushes tomasterand on PRs.tokenhost-web-templatefrom the pnpm workspace so it no longer participates in workspace installs/lockfile resolution and is not pulled into CI.pnpm-lock.yamlaccordingly (removes the legacy template importer + transitive graph).Why
packages/*+apps/*), not the deprecated legacy template pipeline.How to test
pnpm installthenpnpm testNotes