fix(batch): extract the queue name out of an already nested queue option #2807

ericallam · 2025-12-22T21:30:04Z

No description provided.

changeset-bot · 2025-12-22T21:30:08Z

⚠️ No Changeset found

Latest commit: 89305b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-22T21:30:20Z

Walkthrough

A new helper function extractQueueName was introduced to normalize queue name extraction from options that may contain either a string name or a nested name property within double-wrapped objects. This helper is integrated into both locked-background-worker and non-locked code paths, replacing direct queue.name property access. The helper returns undefined when unable to determine a valid name, preserving existing fallback logic for default queue naming.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The change is localized to a single file with a consistent refactoring pattern—extracting queue name logic into a reusable helper and applying it uniformly across code paths. While the logic handles different object shapes, the overall scope is contained and the implementation is straightforward. Review effort is minimal given the homogeneous nature of the changes (same helper applied repeatedly) and clear intent to improve resilience.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author. The description is entirely missing, including all required sections from the template such as testing steps, changelog, and the issue closure.	Add a complete pull request description following the template, including the issue number, checklist completion, testing steps, and changelog entry.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: extracting queue names from nested queue option structures in the batch trigger code.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/batch-trigger-v2-queue-name

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between acc10e8 and 89305b5.

⛔ Files ignored due to path filters (1)

references/hello-world/src/trigger/batches.ts is excluded by !references/**

📒 Files selected for processing (1)

apps/webapp/app/runEngine/concerns/queues.server.ts

🧰 Additional context used

📓 Path-based instructions (6)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

Files:

apps/webapp/app/runEngine/concerns/queues.server.ts

{packages/core,apps/webapp}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use zod for validation in packages/core and apps/webapp

Files:

apps/webapp/app/runEngine/concerns/queues.server.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

Files:

apps/webapp/app/runEngine/concerns/queues.server.ts

apps/webapp/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

Access all environment variables through the env export of env.server.ts instead of directly accessing process.env in the Trigger.dev webapp

Files:

apps/webapp/app/runEngine/concerns/queues.server.ts

apps/webapp/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

apps/webapp/**/*.{ts,tsx}: When importing from @trigger.dev/core in the webapp, use subpath exports from the package.json instead of importing from the root path
Follow the Remix 2.1.0 and Express server conventions when updating the main trigger.dev webapp

Files:

apps/webapp/app/runEngine/concerns/queues.server.ts

**/*.{js,ts,jsx,tsx,json,md,css,scss}

📄 CodeRabbit inference engine (AGENTS.md)

Format code using Prettier

Files:

apps/webapp/app/runEngine/concerns/queues.server.ts

🧬 Code graph analysis (1)

apps/webapp/app/runEngine/concerns/queues.server.ts (1)

packages/trigger-sdk/src/v3/shared.ts (1)

queue (131-138)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (24)

GitHub Check: Cursor Bugbot
GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
GitHub Check: typecheck / typecheck
GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

apps/webapp/app/runEngine/concerns/queues.server.ts (3)
19-46: LGTM! Well-structured helper for handling double-wrapped queue options.

The defensive implementation with runtime type checks is appropriate for handling the unpredictable structure caused by the SDK bug. The function safely handles edge cases by returning undefined, allowing callers to apply their fallback logic.

64-65: LGTM! Proper integration of the queue name extraction.

The helper function is correctly integrated into the locked worker path, maintaining existing validation logic while adding resilience to double-wrapped queue options.

158-161: LGTM! Consistent application of queue name extraction.

The helper is applied consistently in the non-locked path, preserving the existing fallback behavior while adding support for double-wrapped queue options.

To ensure comprehensive coverage, verify that all queue name accesses in the codebase now use this pattern:
#!/bin/bash
# Search for potential direct queue.name accesses that might need the helper

# Look for direct queue.name property accesses
rg -n --type=ts -C3 'queue\.name' -g '!node_modules' -g '!*.test.ts'

# Look for queue option accesses that might need extraction
rg -n --type=ts -C3 'options.*queue' -g '!node_modules' -g '!*.test.ts'

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vibe-kanban-cloud · 2025-12-22T21:33:00Z

Review Complete

Your review story is ready!

View Story

Comment !reviewfast on this PR to re-generate the story.

fix(batch): extract the queue name out of an already nested queue option

89305b5

nicktrn approved these changes Dec 22, 2025

View reviewed changes

ericallam merged commit d820896 into main Dec 22, 2025
32 checks passed

ericallam deleted the fix/batch-trigger-v2-queue-name branch December 22, 2025 21:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(batch): extract the queue name out of an already nested queue option #2807

fix(batch): extract the queue name out of an already nested queue option #2807

ericallam commented Dec 22, 2025

Uh oh!

changeset-bot bot commented Dec 22, 2025

Uh oh!

coderabbitai bot commented Dec 22, 2025 •

edited

Loading

Uh oh!

vibe-kanban-cloud bot commented Dec 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(batch): extract the queue name out of an already nested queue option #2807

fix(batch): extract the queue name out of an already nested queue option #2807

Conversation

ericallam commented Dec 22, 2025

Uh oh!

changeset-bot bot commented Dec 22, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

vibe-kanban-cloud bot commented Dec 22, 2025

Review Complete

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Dec 22, 2025 •

edited

Loading