Fix: We where not expaind the parent nodes in gapfill, only making new node #51
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0hmX
force-pushed
the
we-are-not-expanding
branch
from
b33b76c to
3c2e7ea
Compare
| start, | ||
| end, | ||
| z: primaryEdge.z, | ||
| isBroken: true, |
There was a problem hiding this comment.
I dont understand what this means
There was a problem hiding this comment.
I renamed it to isSegmentSameLengthAsParentEdge
|
Can you help me understand what this is doing? I looked at the snapshot- i dont understand |
|
|
0hmX
force-pushed
the
we-are-not-expanding
branch
from
ae8230c to
68d374e
Compare
|
I added a commit before this so that we can see the difference clearly in the snapshot
|
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
the gap fill stage shouldn't expand nodes, that is doing too much. If we are able to expand an edge it should be done in a prior stage
Because we were making new nodes only, it made super small nodes, which led to a lot of jank. This will not remove all of them but reduce them and is a behavior we want!