fix: scientific notation is incorrectly parsed in general numeric sort#10437
Conversation
Merging this PR will degrade performance by 7.32%
Performance Changes
Comparing Footnotes
|
|
GNU testsuite comparison: |
| #[test] | ||
| fn test_exponents_positive_general() { | ||
| test_helper("exponents-positive-general", &["-g"]); | ||
| } | ||
|
|
There was a problem hiding this comment.
i am not a fan of this test (and the fixtures/sort files)
please test this way:
printf '1\n1e-5' | sort -g
|
GNU testsuite comparison: |
…d_in_general_sort
|
GNU testsuite comparison: |
|
I don't think I would be too worried about the performance regression here since the benchmark was only 1 digit scientific notation numbers anyways so the entire benchmark wasn't even going in this code path before |
ChrisDryden
left a comment
There was a problem hiding this comment.
Just waiting on the CI
Description
This PR fixes the general numeric sort to parse correctly scientific notations with sign
Changes
Fixes #10317