types(jsx): improve autocomplete type #14237
Open
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis change adds comprehensive TypeScript type definitions for HTML autofill attributes in the runtime-dom package. It introduces union and template literal types for various autofill categories (address kinds, contact fields, credential fields, and common field names), along with helper types for optional prefix/postfix tokens. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
edison1105
added
scope: types
🍰 p2-nice-to-have
Member
|
/ecosystem-ci run |
Contributor
|
📝 Ran ecosystem CI: Open
|
KazariEX
reviewed
Dec 23, 2025
Comment on lines
+564
to
+623
| export type AutoFillAddressKind = 'billing' | 'shipping' | ||
| export type AutoFillBase = '' | 'off' | 'on' | ||
| export type AutoFillContactField = | ||
| | 'email' | ||
| | 'tel' | ||
| | 'tel-area-code' | ||
| | 'tel-country-code' | ||
| | 'tel-extension' | ||
| | 'tel-local' | ||
| | 'tel-local-prefix' | ||
| | 'tel-local-suffix' | ||
| | 'tel-national' | ||
| export type AutoFillContactKind = 'home' | 'mobile' | 'work' | ||
| export type AutoFillCredentialField = 'webauthn' | ||
| export type AutoFillNormalField = | ||
| | 'additional-name' | ||
| | 'address-level1' | ||
| | 'address-level2' | ||
| | 'address-level3' | ||
| | 'address-level4' | ||
| | 'address-line1' | ||
| | 'address-line2' | ||
| | 'address-line3' | ||
| | 'bday-day' | ||
| | 'bday-month' | ||
| | 'bday-year' | ||
| | 'cc-csc' | ||
| | 'cc-exp' | ||
| | 'cc-exp-month' | ||
| | 'cc-exp-year' | ||
| | 'cc-family-name' | ||
| | 'cc-given-name' | ||
| | 'cc-name' | ||
| | 'cc-number' | ||
| | 'cc-type' | ||
| | 'country' | ||
| | 'country-name' | ||
| | 'current-password' | ||
| | 'family-name' | ||
| | 'given-name' | ||
| | 'honorific-prefix' | ||
| | 'honorific-suffix' | ||
| | 'name' | ||
| | 'new-password' | ||
| | 'one-time-code' | ||
| | 'organization' | ||
| | 'postal-code' | ||
| | 'street-address' | ||
| | 'transaction-amount' | ||
| | 'transaction-currency' | ||
| | 'username' | ||
| export type OptionalPrefixToken<T extends string> = `${T} ` | '' | ||
| export type OptionalPostfixToken<T extends string> = ` ${T}` | '' | ||
| export type AutoFillField = | ||
| | AutoFillNormalField | ||
| | `${OptionalPrefixToken<AutoFillContactKind>}${AutoFillContactField}` | ||
| export type AutoFillSection = `section-${string}` | ||
| export type AutoFill = | ||
| | AutoFillBase | ||
| | `${OptionalPrefixToken<AutoFillSection>}${OptionalPrefixToken<AutoFillAddressKind>}${AutoFillField}${OptionalPostfixToken<AutoFillCredentialField>}` |
Member
There was a problem hiding this comment.
I don't think these types should be exported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is sourced from DefinitelyTyped
Summary by CodeRabbit
autocompleteattributes with comprehensive type definitions, providing better IDE autocomplete suggestions and improved type safety for form fields including billing, shipping, contact, and credential-related input types.✏️ Tip: You can customize this high-level summary in your review settings.