Open
Conversation
j0k3r
reviewed
Jan 21, 2021
Member
j0k3r
left a comment
There was a problem hiding this comment.
Looks ok, any chance to add a new test to cover that behavior?
5efaf08 to
dfc3a38
Compare
Author
|
done |
|
@Kdecherf any chance of getting this merged? |
Member
|
@deafmute1 I'll try to review this PR in the coming weeks |
|
Any update on this? This was a good PR and necessary to support docker secrets. |
|
Is there a way to help review/merge this ? |
|
Is there a chance that this will get merged at some point? |
Member
"coming weeks" 😬 I'll dedicate some time next month to review this, sorry for taking this long |
jbrobst
reviewed
Sep 6, 2025
| [[ ! $? -eq 0 ]] && exit 1 # Exit if last command failed | ||
| new_var="$(echo $var_name=$file_content)" | ||
| export $(echo $new_var | xargs) | ||
| done |
There was a problem hiding this comment.
Missing some quoting here and [[ is bash-specific. This is sh, so maybe replace this whole block with something like:
for n in $(LC_ALL=C awk 'BEGIN {for (n in ENVIRON) if (n ~ /^[0-9A-Z_]+__FILE$/) print n}'); do
if ! eval "${n%__FILE}=\$(cat -- \"\$$n\") && export ${n%__FILE}"; then
printf 'Failed to read $%s\n' "$n" >&2
exit 1
fi
donec78c7d0 to
919bdbd
Compare
919bdbd to
710d3e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.