-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Major UI Revamp #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major UI Revamp #268
Conversation
- Add "New Project" button to empty tab state - Round cost display to 2 decimal places in usage dashboard - Fix agent history tab to show local timezone and proper metrics 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add tab persistence service to save/restore tabs to localStorage - Add session persistence service to save/restore chat session data - Update TabContext to restore saved tabs and session data on app startup - Add settings toggle to enable/disable tab persistence - Fix TypeScript errors in AgentRunWithMetrics interface - Sessions now resume properly when app is reopened 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…election to tabs\n\n- Remove unused icons/components and dead handlers (e.g., directory selection) across UI components\n- Drop unused callbacks from props (onBack, onMCPClick, onUsageClick, etc.)\n- Fix createAgentsTab reference in App.tsx\n- Silence TypeScript lints by renaming unused vars (e.g., _error, _className)\n- Centralize project path selection in tab controls
- Only set minimal first_message for restored sessions; drop placeholder metrics - Align with API expectations and avoid misleading defaults
- Add drag-region helpers (.tauri-drag/.tauri-no-drag)\n- Apply transparent background and clip-path rounding\n- Define theme tokens and typography utilities\n- Refine scrollbars and markdown editor/prose styles
- Window minimize/maximize/close via Tauri API\n- Hover-revealed control icons, improved spacing\n- Agents/Usage buttons with tooltips and motion\n- More options dropdown for Claude, MCP, About
|
Claude finished @123vivekr's task —— View job PR Review AnalysisReview complete! Here's my comprehensive analysis of this major UI revamp:
🟢 Code Quality & Best PracticesStrong Points:
Areas for Improvement:
🟡 Potential Bugs & IssuesCritical Issues:
Moderate Issues:
⚡ Performance ConsiderationsMajor Concerns:
Recommendations:
🔒 Security ConcernsSecure Implementation Found ✅
Minor Considerations:
❌ Test CoverageMajor Concern - Zero Test Coverage:
Essential Testing Strategy Needed:
📋 Key Technical FindingsArchitectural Strengths:
Code Quality Metrics:
🚨 Priority Recommendations
✅ Final AssessmentThis is a high-quality major UI revamp that demonstrates excellent React and TypeScript engineering. The custom titlebar, sophisticated tab management, and agent execution features are well-architected and production-ready. Primary Blocker: The complete absence of tests for a 33k+ line codebase is concerning for production deployment. Recommendation: Approve after adding basic test coverage for critical paths (persistence services, tab management). The architectural foundation is solid. Overall Score: 8/10
|
No description provided.