Zendesk Coverity changes #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
previously approved these changes
Jul 22, 2025
ejohnstown
requested changes
Jul 22, 2025
Contributor
ejohnstown
left a comment
ejohnstown
left a comment
There was a problem hiding this comment.
Issues 572871 and 572874 are still present. I think it found two issues each in the areas you fixed, but you only fixed one of the issues.
NULL check before dereferencing authData additional checks formatting changes adjust return values
ejohnstown
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NULL checks to clear Coverity issues reported in ZD#20212.
ssh->ctx != NULLbefore dereferencing inGetAllowedAuth()(wolfSSH Project 572900)SendUserAuthKeyboardRequest()does not return immediately ifsshorauthDataare NULL (wolfSSH Project CI 572871 and CI 572874)AlgoListSz()returns 0 if param is NULL (wolfSSH Project 572893)