Fips bsdkm #9590
Open
Fips bsdkm #9590
+332
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Contributor
Author
|
Retest this please. (Found unhandled jenkins exception). |
douzzer
requested changes
Jan 9, 2026
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
small stuff -- just the trivial refactor to use WOLFSSL_DEBUG_PRINTF().
Comment on lines
+47
to
+48
| #define wc_km_printf printf | ||
| #define wc_km_print_err printf |
Contributor
There was a problem hiding this comment.
we don't need these -- the existing WOLFSSL_DEBUG_PRINTF() does the trick nicely.
Comment on lines
+1433
to
+1434
| #define wc_km_print_err pr_err | ||
|
|
Contributor
There was a problem hiding this comment.
as noted above, WOLFSSL_DEBUG_PRINTF() is the existing way to do this.
| (void)arg; | ||
|
|
||
| return (ret); | ||
| return (error); |
Contributor
There was a problem hiding this comment.
interesting -- so in BSD, error codes are returned as positive numbers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support wolfcrypt FIPS in FreeBSD kernel.
Adds a bsdkm/README.md
Requires:
Testing
See readme: