Skip to content

fix: normalize path for createAnalytics of analytics/index.ts#2013

Merged
PatrykKuniczak merged 5 commits intowxt-dev:mainfrom
PatrykKuniczak:fix/analysis-windows-import-path
Feb 8, 2026
Merged

fix: normalize path for createAnalytics of analytics/index.ts#2013
PatrykKuniczak merged 5 commits intowxt-dev:mainfrom
PatrykKuniczak:fix/analysis-windows-import-path

Conversation

@PatrykKuniczak
Copy link
Collaborator

Overview

I've use normalize path for createAnalysis func in output.

Manual Testing

Let's run pnpm -F analytics prepare and see new output of .wxt/analytics/index.ts, should be valid independent of OS.

Related Issue

This PR closes #2008

@netlify
Copy link

netlify bot commented Dec 21, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 7ce2566
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6988504049dbe10008a56dd1
😎 Deploy Preview https://deploy-preview-2013--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PatrykKuniczak PatrykKuniczak force-pushed the fix/analysis-windows-import-path branch from cfc29de to c790009 Compare December 24, 2025 13:10
@PatrykKuniczak PatrykKuniczak force-pushed the fix/analysis-windows-import-path branch from c790009 to 0796e05 Compare February 6, 2026 19:02
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 6, 2026

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2013

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2013

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2013

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2013

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2013

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2013

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2013

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2013

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2013

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2013

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2013

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2013

wxt

npm i https://pkg.pr.new/wxt@2013

commit: 7ce2566

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.06%. Comparing base (3a3953e) to head (7ce2566).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2013      +/-   ##
==========================================
- Coverage   76.13%   76.06%   -0.07%     
==========================================
  Files         113      113              
  Lines        3050     3050              
  Branches      686      686              
==========================================
- Hits         2322     2320       -2     
- Misses        645      647       +2     
  Partials       83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PatrykKuniczak PatrykKuniczak force-pushed the fix/analysis-windows-import-path branch 2 times, most recently from 1df2fc2 to 323c89c Compare February 7, 2026 07:41
@PatrykKuniczak
Copy link
Collaborator Author

@aklinker1 I'm also simplified import path in output file:
image

@PatrykKuniczak PatrykKuniczak enabled auto-merge (squash) February 7, 2026 07:42
@PatrykKuniczak
Copy link
Collaborator Author

@aklinker1 OK, IT DOESN'T WORK xD
Reverted

@aklinker1
Copy link
Member

aklinker1 commented Feb 7, 2026

Ok. Export normalizePath, but don't add a new export path for it - those are for runtime utils only. Export it from wxt directly since it's a build time util.

Edit: Actually, we should break this PR apart, one for exporting normalizePath from WXT so it get's a dedicated entry in the changelog next release.

@PatrykKuniczak PatrykKuniczak force-pushed the fix/analysis-windows-import-path branch from 9bc0a4b to 194ff3a Compare February 8, 2026 08:57
@PatrykKuniczak
Copy link
Collaborator Author

PatrykKuniczak commented Feb 8, 2026

@aklinker1 Are you able to enable update with rebase as default and only option?
This change can enforce devs to resolve conflicts before merge PR :)
Because of:
image

@PatrykKuniczak
Copy link
Collaborator Author

@aklinker1 Finally DONE :)

@PatrykKuniczak PatrykKuniczak merged commit 1fe0730 into wxt-dev:main Feb 8, 2026
18 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

Thanks for helping make WXT better!

@aklinker1
Copy link
Member

@aklinker1 Are you able to enable update with rebase as default and only option? This change can enforce devs to resolve conflicts before merge PR :)
Because of:
image

No, that's not a setting on github. You can't merge a PR without resolving conflicts anyways, either a merge commit or a rebase both do the job.

@PatrykKuniczak PatrykKuniczak deleted the fix/analysis-windows-import-path branch February 8, 2026 14:28
@PatrykKuniczak
Copy link
Collaborator Author

@aklinker1 But if you can(if you didn't done it already), let's enable auto removing branches after merge, it'll be useful at least on our branches(because with auto-merge) i usually doesn't check PR after merge, with auto branch remove, we can avoid a loot of old unnecessary branches :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error on run pnpm check for analytics package

2 participants