Remove coverage generation from Shifter #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage generation should now be performed using other tools, for example: * using Yeti; or * a grunt task calling istanbul.
Contributor
There was a problem hiding this comment.
Bumping the version strikes me as premature, and entirely unrelated to this pull request.
Member
There was a problem hiding this comment.
agreed, this step is done by the build process triggered by the person doing the release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in other issues, there's no need for Shifter to generate coverage files any more. This commit removes all traces of both yetitest, and istanbul. I've moved istanbul to being a devDependency as it's used for the coverage of Shifter itself.
Coverage generation should now be performed using other tools, for example:
This will also remove the need for it to be documented as raised in #125