refactor: Split read benchmarks and add addParquetScanCases helper#3407
Open
andygrove wants to merge 4 commits intoapache:mainfrom
Open
refactor: Split read benchmarks and add addParquetScanCases helper#3407andygrove wants to merge 4 commits intoapache:mainfrom
andygrove wants to merge 4 commits intoapache:mainfrom
Conversation
Extract iceberg benchmarks into CometIcebergReadBenchmark and add addParquetScanCases helper to CometBenchmarkBase to eliminate the repeated 3-case pattern (Spark / native_datafusion / native_iceberg_compat) across all parquet benchmarks. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Eliminate the JVM data round trip for data columns in native_iceberg_compat scans. Data columns are read directly from the native BatchContext via zero-copy Arc::clone, while only partition columns cross the JVM boundary via Arrow FFI. Previously, data made a wasteful round trip: Rust ParquetSource → per-column JNI export to JVM → JVM wraps as CometVector → JVM exports ALL cols back to Rust via Arrow FFI → Rust ScanExec deep-copies every column Now in passthrough mode: Rust ParquetSource → batch stays in native BatchContext → Rust ScanExec reads data cols directly (zero-copy) → Only partition cols imported from JVM FFI (small, constant) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…cans" This reverts commit 75750af.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CometReadBaseBenchmarkinto newCometIcebergReadBenchmarkobjectaddParquetScanCaseshelper toCometBenchmarkBasethat encapsulates the repeated 3-case pattern (Spark / native_datafusion / native_iceberg_compat) used by all parquet benchmarksCometReadBaseBenchmarkandCometPartitionColumnBenchmarkto use the new helper, eliminating ~270 lines of duplicated boilerplateTest plan
./mvnw compile test-compile -pl spark -DskipTestspasses./mvnw spotless:check -pl sparkpassesCometReadBenchmarkto verify parquet benchmarks workCometIcebergReadBenchmarkto verify iceberg benchmarks workCometPartitionColumnBenchmarkto verify partition benchmarks work🤖 Generated with Claude Code