fix: sell estimation precision and tests #50
Merged
+296
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulriera
commented
Jan 31, 2026
| } | ||
|
|
||
| private var shouldShowAppreciation: Bool { | ||
| appreciation.amount.decimalValue >= 0.01 |
Collaborator
Author
There was a problem hiding this comment.
Adding a little wiggle room here because appreciation could be REALLY small (281 quarks as I write this comment). So only display values around 0.01
bmc08gt
approved these changes
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes around balance appreciation calculations, the bonding curve logic, and UI handling for appreciation display. The most significant changes include making cost basis non-optional and defaulting to zero, updating the bonding curve to clamp oversell scenarios (matching Android behavior), and ensuring appreciation is only shown when meaningful. Additionally, the bonding curve logic now uses higher-precision arithmetic for consistency across platforms.