fix: sell estimation precision and tests #50
+296
−48
Merged
Xcode Cloud / Flipcash | Deploy Flipcash | Archive - iOS
succeeded
Feb 1, 2026 in 22m 12s
27 warnings
| Report Summary | |
|---|---|
| Errors | 0 |
| Test Failures | 0 |
| Analysis Issues | 0 |
| Warnings | 27 |
Details
27 Warnings
Details
Generated a new Google plist.Search path '/Volumes/workspace/repository/CodeScanner/.build/arm64-apple-ios-simulator/debug' not foundFlipcashCore/Sources/FlipcashCore/Clients/Payments API/Services/MessagingService.swift:129
Capture of 'reference' with non-Sendable type 'StreamReference?' in a '@Sendable' closureFlipcashCore/Sources/FlipcashCore/Models/BondingCurve.swift:71
'BondingCurve' is deprecated: Use DiscreteBondingCurve instead for deterministic pricingFlipcashCore/Sources/FlipcashCore/Clients/Payments API/Services/TransactionService.swift:468
Capture of non-Sendable type 'T.Type' in an isolated closureFlipcashCore/Sources/FlipcashCore/Models/BondingCurve.swift:185
'BondingCurve' is deprecated: Use DiscreteBondingCurve instead for deterministic pricingFlipcashCore/Sources/FlipcashCore/Clients/Payments API/Services/MessagingService.swift:129
Capture of 'self' with non-Sendable type 'MessagingService?' in a '@Sendable' closureFlipcashUI/Sources/FlipcashUI/View Controllers/PhotoPickerView.swift:66
Capture of 'didSelect' with non-Sendable type '(UIImage) -> Void' in a '@Sendable' closureFlipcashCore/Sources/FlipcashCore/Formatters/CurrencyFormatter.swift:103
'components(fromIdentifier:)' was deprecated in iOS 16: Use `Locale.Components(identifier:)` to access componentsFlipcashCore/Sources/FlipcashCore/Clients/Payments API/Services/AccountInfoService.swift:36
Variable 'account' was never mutated; consider changing to 'let' constantFlipcashCore/Sources/FlipcashCore/Clients/Payments API/Services/MessagingService.swift:108
Clean up messages at some point?Flipcash/Core/Screens/Main/ScanScreen.swift:432
Extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the futureFlipcashCore/Sources/FlipcashCore/Clients/Payments API/Services/MessagingService.swift:102
Variable 'self' was written to, but never readFlipcash/Core/Screens/Settings/WithdrawAmountScreen.swift:29
Add support for max withdrawalFlipcash/Core/Screens/Onboarding/OnboardingViewModel.swift:350
Immutable value 'finishTransaction' was never used; consider replacing with '_' or removing itFlipcash/Core/Screens/Onramp/OnrampViewModel.swift:639
Value 'selectedPreset' was defined but never used; consider replacing with boolean testFlipcashCore/Sources/FlipcashCore/Vendor/Base58.swift:70
'init(encodedOffset:)' is deprecated: encodedOffset has been deprecated as most common usage is incorrect. Use String.Index(utf16Offset:in:) to achieve the same behavior.FlipcashCore/Sources/FlipcashCore/Clients/Payments API/Services/SwapService.swift:227
Capture of 'completion' with non-Sendable type '(Result) -> Void' in a '@Sendable' closureFlipcashUI/Sources/FlipcashUI/Views/Containers/SheetView.swift:49
'animation' was deprecated in iOS 15.0: Use withAnimation or animation(_:value:) instead.Flipcash/Core/Screens/Settings/WithdrawSummaryScreen.swift:55
Initialization of immutable value 'usdcFiat' was never used; consider replacing with assignment to '_' or removing itFlipcashCore/Sources/FlipcashCore/Vendor/Base58.swift:95
'encodedOffset' is deprecated: encodedOffset has been deprecated as most common usage is incorrect. Use utf16Offset(in:) to achieve the same behavior.FlipcashUI/Sources/FlipcashUI/Views/Preview.swift:35
Extension declares a conformance of imported type 'PreviewDevice' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'SwiftUI' introduce this conformance in the futureFlipcashCore/Sources/FlipcashCore/Extensions/UnaryCall+Extensions.swift:14
Type 'ResponsePayload' does not conform to the 'Sendable' protocolFlipcashCore/Sources/FlipcashCore/Models/BondingCurve.swift:325
'BondingCurve' is deprecated: Use DiscreteBondingCurve instead for deterministic pricingFlipcash/Core/Controllers/Database/Models/StoredBalance.swift:44
Immutable value 'sellFeeBps' was never used; consider replacing with '_' or removing itFlipcashCore/Sources/FlipcashCore/Models/CurrencyCode.swift:258
'currencyCode' was deprecated in iOS 16: renamed to 'currency.identifier'Flipcash/Core/Screens/Settings/DepositDescriptionScreen.swift:38
'init(isActive:destination:label:)' was deprecated in iOS 16.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
Loading